Adjust AWS keys for Archivematica SIPs #1233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd like the code reviewer's input on that line length flag. In my mind, it's more readable in a single line since it's only four characters over the limit, but I could be persuaded. |
JPrevost
reviewed
Sep 29, 2023
| @@ -19,7 +19,7 @@ def initialize(sip) | |||
| # This key needs to be unique. By default, ActiveStorage generates a UUID, but since we want a file path for our | |||
| # Archivematica needs, we are generating a key. We handle uniqueness on the `bag_name` side. | |||
| def keygen(sip) | |||
| "etdsip/#{sip.thesis.accession_number}/#{sip.bag_name}.zip" | |||
| "etdsip/#{sip.thesis.graduation_year}/#{sip.thesis.graduation_month}-#{sip.thesis.accession_number}/#{sip.bag_name}.zip" | |||
There was a problem hiding this comment.
Because you asked...
I think:
def keygen(sip)
thesis = sip.thesis
"etdsip/#{thesis.graduation_year}/#{thesis.graduation_month}-#{thesis.accession_number}/#{sip.bag_name}.zip"
endretains readability and addresses the line length. I'm never one to force a change because a bot whined about it though, so I wouldn't say this is a required change.
Another option I feel is less readable (but you may disagree so I'll share it as well) is:
['etdsip',
sip.thesis.graduation_year,
"#{sip.thesis.graduation_month}-#{sip.thesis.accession_number}",
sip.bag_name].join('/')
JPrevost
approved these changes
Sep 29, 2023
Why these changes are being introduced: We recently merged a proposed solution to this. However, looking back at ETD-600, I realized I have the spec wrong. The current keys are missing the graduation year and month. Relevant ticket(s): https://mitlibraries.atlassian.net/browse/ETD-593 How this addresses that need: This updates the keys to what Joe originally requested, so that the SIP directory includes the grad month and is nested beneath the grad year. For example: `etdsip/2023/June-2023_001` Side effects of this change: None.
jazairi
force-pushed
the
etd-593-update-aws-keys
branch
from
4a7b538
to
3ab83b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why these changes are being introduced:
We recently merged a proposed solution to this. However, looking back at ETD-600, I realized I have the spec wrong. The current keys are missing the graduation year and month.
Relevant ticket(s):
https://mitlibraries.atlassian.net/browse/ETD-593
How this addresses that need:
This updates the keys to what Joe originally requested, so that the SIP directory includes the grad month and is nested beneath the grad year. For example:
etdsip/2023/June-2023_001Side effects of this change:
None.
Developer
our guide and
all issues introduced by these changes have been resolved or opened as new
issues (link to those issues in the Pull Request details above)
Code Reviewer
(not just this pull request message)
Requires database migrations?
NO
Includes new or updated dependencies?
NO